dpogue opened a new pull request, #1702:
URL: https://github.com/apache/cordova-ios/pull/1702

   
   ### Platforms affected
   iOS
   
   ### Description
   <!-- Describe your changes in detail -->
   We've annotated CDVPluginResult messageAsString: to only accept a non-nil 
argument, but this test is specifically intended to make sure that if it does 
get a nil argument it doesn't blow up. The static analyzer (rightfully) 
complains about passing nil to a method that requires non-nil, but we'll just 
silence that in this specific case.
   
   UIOpenURLContext requires that options return a non-nil object, so use the 
same hack to default construct a UISceneOpenURLOptions that we did for 
UISceneSession.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Tests pass locally.
   
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to