dpogue opened a new pull request, #2010:
URL: https://github.com/apache/cordova-android/pull/2010

   **Not finished, not completely working,** but might be good to get some eyes 
on this.
   Hacky test project: 
https://gist.github.com/dpogue/f548df1ec6adf2662485b29599688f23
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   
   
   ### Description
   <!-- Describe your changes in detail -->
   - Fixes the issue where insets were not zeroed out when the WebView was not 
displayed edge-to-edge
   
   ### TODO
   - [ ] JS to set `StatusBarBackgroundColor` preference as 
`cdv_statusbar_background_color ` in cdv_colors.xml during prepare
   - [ ] JS to observe changes to the viewport and theme-color meta tags
   - [ ] Figure out what to do if the webview is not up to date and doesn't 
support `safe-area-inset` variables
   - [ ] Figure out what to do with the navigation bar
   - [ ] Finish moving the rest of the view logic from SystemBarPlugin to 
CordovaActivity
   - [ ] Make sure hiding the status bar entirely works
   - [ ] Make sure fullscreen mode works
   - [ ] Make sure immersive mode works
   - [ ] Test every combination on every single SDK from 24 to 37 and document 
the results 😩 
   - [ ] Figure out if this breaks existing behaviour in cordova-android 15.x
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to