[ 
https://issues.apache.org/jira/browse/CB-5400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823815#comment-13823815
 ] 

Carlos Santana commented on CB-5400:
------------------------------------

this pull request has more changes than the version problem about 4 fields.

As better practice one pull request should resolve one Jira Issue.

What jira issues are the other commits fixing? please explain
SomaticIT       Update Identity.Name in package.appxmanifest    1da2a96

SomaticIT       Append author property to config_parser 912e012

SomaticIT       Update appxmanifest properties' DisplayName and PublisherName   
02162b4



> Version and Id is not set correctly in Windows 8 application project file
> -------------------------------------------------------------------------
>
>                 Key: CB-5400
>                 URL: https://issues.apache.org/jira/browse/CB-5400
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, Windows 8
>            Reporter: Maxime LUCE
>            Assignee: Maxime LUCE
>
> When using CLI with Windows 8 Platform :
> 1. Cordova default version string is not compatible with Windows 8 one (0.0.0 
> vs 0.0.0.0) so add a .0 automatically.
> 2. In package.appxmanifest, Application.id must be a safe name, which is not 
> actually, we can use packageName (which is safe) or compute a safe name based 
> on config name.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to