[ 
https://issues.apache.org/jira/browse/CB-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13841625#comment-13841625
 ] 

ASF subversion and git services commented on CB-3762:
-----------------------------------------------------

Commit 96c5fa74ef80fd26e01aced561adc341a11b93fd in branch refs/heads/dev from 
[~mrbillau]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-dialogs.git;h=96c5fa7 ]

CB-3762 Change prompt default to empty string


> notification.prompt doesn't accept an empty string for default text
> -------------------------------------------------------------------
>
>                 Key: CB-3762
>                 URL: https://issues.apache.org/jira/browse/CB-3762
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Dialogs
>    Affects Versions: 2.7.0, 2.8.0
>            Reporter: Todd Miller
>            Assignee: Mike Billau
>            Priority: Minor
>             Fix For: 3.3.0
>
>
> Specifying "" as the last parameter for navigator.notification.prompt, the 
> prompt dialog will still show "Default Text" in the text input box. However, 
> putting a string of just a single space works (but also results in a space in 
> the text box).
> In additional seems like the default of "Default Text" isn't the best choice 
> from UX perspective. A default of an empty text box would make more sense.
> Changing line 5909 in cordova.js from:
> var _defaultText = (defaultText || "Default text");
> to
> var _defaultText = (defaultText || "");
> Resolves the issue and gives a blank text box by default. Documentation would 
> also need to be updated with the new default if this is adopted.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to