[
https://issues.apache.org/jira/browse/CB-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853982#comment-13853982
]
Marcel Kinard edited comment on CB-5447 at 12/20/13 2:22 PM:
-------------------------------------------------------------
I did look at this a bit. Externally, Dirk-Jan's request makes sense.
The android manifest gets updated for other settings by the cli during the
"prepare" step. That would be the logical place to add the code to update
android:debuggable in the android manifest. However, the "\-\-release" option
is used by the "compile" step, which has a simple branch to call "ant debug" or
"ant release" depending on the arg passed in to it. That is the logical place
to read the "\-\-release" option.
The easy route would be to add the android:debuggable handling in prepare's
android_parser.js script, but require that "\-\-release" also be passed in to
"prepare". But it doesn't feel right to put the debug/release processing in
both "prepare" and "compile", so I'm thinking about having the "\-\-release"
branch in "compile" set android:debuggable in the manifest. Would this be in
keeping with the spirit of the CLI design?
was (Author: cmarcelk):
I did look at this a bit. Externally, Dirk-Jan's request makes sense.
The android manifest gets updated for other settings by the cli during the
"prepare" step. That would be the logical place to add the code to update
android:debuggable in the android manifest. However, the "--release" option is
used by the "compile" step, which has a simple branch to call "ant debug" or
"ant release" depending on the arg passed in to it. That is the logical place
to read the "--release" option.
The easy route would be to add the android:debuggable handling in prepare's
android_parser.js script, but require that "--release" also be passed in to
"prepare". But it doesn't feel right to put the debug/release processing in
both "prepare" and "compile", so I'm thinking about having the "--release"
branch in "compile" set android:debuggable in the manifest. Would this be in
keeping with the spirit of the CLI design?
> Release build Android keeps android:debuggable=“true”
> -----------------------------------------------------
>
> Key: CB-5447
> URL: https://issues.apache.org/jira/browse/CB-5447
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, CLI
> Affects Versions: 3.0.0, 3.1.0
> Environment: OS X Mavericks
> Reporter: Dirk-Jan Hoek
>
> I'm trying to release an Android app using the CLI.
> When running 'cordova build android --release', I noticed the following
> setting in AndroidManifest.xml: "android:debuggable="true".
> This setting prevents anyone from uploading to the Play Store.
> I've solved this by adding a cordova-hook that sets this value to "false".
> Shouldn't this be done by default when building with the '--release' flag?
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
