[
https://issues.apache.org/jira/browse/CB-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867027#comment-13867027
]
Shazron Abdullah commented on CB-3208:
--------------------------------------
Please consider for the future (see Step 3
http://wiki.apache.org/cordova/ProcessingPullRequests) eg squashing this 21
commit feature PR#16 into one commit, right now if there are problems with it,
referring to the change will be harder, not to mention if this change for
whatever reason needs to be backed out. Also, just perusing the git log you
won't know that this is all part of one feature, to easily communicate to
others.
Piotr also a suggestion - the PR#16 itself was in your master branch, it should
be in a topic branch. If you continued to add to master (which may have been
possible while waiting for this PR to be processed), the commits would show up
as part of the PR, which may not be what was intended
> contacts
> --------
>
> Key: CB-3208
> URL: https://issues.apache.org/jira/browse/CB-3208
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: FirefoxOS
> Affects Versions: 2.6.0
> Reporter: Herm Wong
> Assignee: Herm Wong
> Fix For: 3.4.0
>
>
> Contacts API spec: https://wiki.mozilla.org/WebAPI/ContactsAPI
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
