[ 
https://issues.apache.org/jira/browse/CB-5026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875237#comment-13875237
 ] 

Shazron Abdullah commented on CB-5026:
--------------------------------------

This is definitely a user hostile move -- they won't understand it since doing 
all this is fundamental to the core experience. However, I think there is some 
utility to separating it out into its own plugin that is included in the core 
(just like CDVLocalStorage). Not sure if there is any upgrade hassle there - 
probably in Embedding the Cordova WebView, not sure.

What do you think? 

In any case there are bigger fish to fry, so deferring this issue is fine.

> Move setting of UIWebView properties into its own plugin from the core
> ----------------------------------------------------------------------
>
>                 Key: CB-5026
>                 URL: https://issues.apache.org/jira/browse/CB-5026
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: iOS
>    Affects Versions: Master
>            Reporter: Shazron Abdullah
>            Assignee: Shazron Abdullah
>            Priority: Minor
>             Fix For: 3.4.0
>
>
> See: 
> https://github.com/apache/cordova-ios/blob/c66fc82bd0a49b940e0a5beb1563ecdb48cc7120/CordovaLib/Classes/CDVViewController.m#L245-L400
> (except for the CDVLocalStorage stuff)
> This 150 line behemoth should be in its own plugin (with onload="true"). Not 
> sure about removing it from core, but putting it in its own plugin in core is 
> a start. 
> Pros:
> - if iOS >= 8 adds more properties, and people want to stick to Cordova 3.A 
> and we only support it in 3.B or 4.x, they only have to update a plugin and 
> not the whole core.
> Cons:
> - if they rely on these settings, they will lose them when they upgrade if 
> they don't install a plugin, this won't be any different when they moved from 
> 2.x to 3.x
> - Yet Another Repo?
> NOTE:
> Do not forget to add docs, and upgrading docs.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to