[jira] [Created] (CB-5984) WP8 add/remove dll resources is crufty

[Jesse MacFadyen (JIRA)]

Jesse MacFadyen created CB-5984:
-----------------------------------

             Summary: WP8 add/remove dll resources is crufty
                 Key: CB-5984
                 URL: https://issues.apache.org/jira/browse/CB-5984
             Project: Apache Cordova
          Issue Type: Bug
          Components: Plugman, WP8
    Affects Versions: 3.4.0
         Environment: Windows
            Reporter: Jesse MacFadyen
            Assignee: Jesse MacFadyen
             Fix For: 3.5.0


plugman + wp8 has support for adding/removing dll resources to the project, 
although there are multiple potential issues with string comparison in 
filesnames.

Code like this:
{code:javascript}
var parts = relative_path.split('\\');
var dll_name = parts[parts.length - 1].substr(0, parts[parts.length - 1].length 
- 4);

{code}

Can easily be replaced with this :
{code:javascript}
var dll_name = path.basename(relative_path, '.dll');
{script}

I fear there are also latent bugs here, so more tests should also be added.




--
This message was sent by Atlassian JIRA
(v6.1.5#6160)