[
https://issues.apache.org/jira/browse/CB-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13896986#comment-13896986
]
ASF subversion and git services commented on CB-5990:
-----------------------------------------------------
Commit c2206c4031a0f56bc74a18801153af5171bf2a67 in branch refs/heads/master
from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=c2206c4 ]
CB-5990 Delete unused findPlugins() function
> findPlugins function doesn't honor its comment
> ----------------------------------------------
>
> Key: CB-5990
> URL: https://issues.apache.org/jira/browse/CB-5990
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugman
> Affects Versions: 3.3.0
> Reporter: Josh Soref
>
> This is the code:
> {quote}
> // List the directories in the path, ignoring any files, .svn, etc.
> findPlugins:function(plugins_dir) {
> var plugins = [],
> stats;
> if (fs.existsSync(plugins_dir)) {
> plugins = fs.readdirSync(plugins_dir).filter(function (fileName) {
> stats = fs.statSync(path.join(plugins_dir, fileName));
> return fileName != '.svn' && fileName != 'CVS' &&
> stats.isDirectory();
> {quote}
> It will return .hg, .git, .bzr, ...
> There's no reason to only special case .svn and CVS, but to not mention CVS
> in the comment.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
