[ 
https://issues.apache.org/jira/browse/CB-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935756#comment-13935756
 ] 

Josh Soref commented on CB-6160:
--------------------------------

[~stevegill]: That merge is unfortunate.

cordova create yip; cd yip; cordova platform add android ios blackberry10; node 
--debug-brk cordova plugin add org.cordova.mobile-spec-dependencies 
--searchpath ~/Cordova/cordova-mobile-spec; cordova plugin remove 
org.cordova.mobile-spec-dependencies; cordova plugin

Failed to install 'org.cordova.mobile-spec-dependencies':TypeError: Arguments 
to path.join must be strings
    at path.js:360:15
    at Array.filter (native)
    at Object.exports.join (path.js:358:36)
    at cordova-plugman/src/install.js:338:39

commit ae2ce7ac6325d1c6558365b4be82e5a8ff0983b9
Author: [~jbondc]
+                    dep.subdir = path.join(dep.subdir.split('/'));
...
-                        dep_subdir = path.join.apply(null, 
dep_subdir.split('/'));

Broke this. I'm not sure what sort of testing people are doing. But I'm not a 
fan. At the very least the test which I'm showing above should pass for each 
and every change to plugman.

> adding plugin fails for Firefoxos. 
> -----------------------------------
>
>                 Key: CB-6160
>                 URL: https://issues.apache.org/jira/browse/CB-6160
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>            Reporter: Gert-Jan Braas
>            Priority: Blocker
>
> reason:  
> No xml_helpers defined ( in src/platforms/firefoxos.js)



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to