[
https://issues.apache.org/jira/browse/CB-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949596#comment-13949596
]
ASF GitHub Bot commented on CB-2606:
------------------------------------
Github user cmarcelk commented on the pull request:
https://github.com/apache/cordova-cli/pull/126#issuecomment-38831161
In a broad sense this looks reasonable.
In the config.xml, why is there width and height attributes when using
cdv:platform="android" and cdv:density="mdpi"? Is hope to reuse the same <icon>
element for iOS and other non-Android platforms? But doing so doesn't seem like
it is meant to be compatible with cdv:platform="android". Or is it meant to be
an alternate way of specifying cdv:density="mdpi" in the Android case?
I don't see where your code uses the "id" attribute in the <icon> element.
What is that element supposed to do? And what happens when it's not present in
the <icon> element?
It would be great to see some corresponding docs for this (i.e.,
cordova-docs). Those docs would describe from the end-users view how they would
consume this new capability.
When it inevitably comes time to do this for splash screens, will this icon
approach work for splash screens?
> Add support for <icon> elements in config.xml
> ---------------------------------------------
>
> Key: CB-2606
> URL: https://issues.apache.org/jira/browse/CB-2606
> Project: Apache Cordova
> Issue Type: Wish
> Components: Docs
> Reporter: Filip Maj
> Assignee: Mark Koudritsky
>
> This feature would add support for specifying the application icon by
> changing values inside the {{config.xml}} document.
> Relevant details for Cordova:
> - {{<icon>}} elements _may_ have {{width}} and {{height}} attributes
> representing the preferred size of the icon in CSS pixels.
> - {{<icon>}} elements _must_ have a {{src}} attribute, which contains a path
> string relative to the {{www/}} folder (or equivalent) in the platform.
> See [the Widget Spec's section on
> icons|http://www.w3.org/TR/widgets/#the-icon-element-and-its-attributes] for
> specifics.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
