[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958959#comment-13958959
]
ASF GitHub Bot commented on CB-6329:
------------------------------------
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/151#discussion_r11260509
--- Diff: src/info-utils.js ---
@@ -0,0 +1,58 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+*/
+ var cordova_util = require('./util'),
+ child_process = require('child_process'),
+ path = require('path'),
+ fs = require('fs'),
+ _self;
+
+_self = {
+
+ getNodeInfo: function( callback ){
+ _self.execFunc('node', '--version', function(call){callback("Node
version: "+call);});
+ },
+
+ getCordovaInfo: function( callback ){
+ _self.execFunc('cordova', '--version',
function(call){callback("Cordova version: "+call);});
+ },
+
+ getPlatformInfo: function(platform, projectRoot, callback ){
+ var command="", args="";
+ switch( platform ){
+ case "ios":
+ _self.execFunc('xcodebuild', '-version',
function(call){callback('iOS Platform:\n\n' +call);});
+ break;
+ case "android":
+ _self.execFunc('android', 'list target',
function(call){callback('Android Platform:\n\n' +call);});
+ break;
+ }
+ },
+
+ execFunc: function(command, args, callback){
--- End diff --
Feel free to ignore me and leave as-is, but might simplify to use
superspawn instead of this, since that already returns a promise.
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -----------------------------------------------------------------
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
> Affects Versions: 3.4.0
> Reporter: Martin Gonzalez
> Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
