[
https://issues.apache.org/jira/browse/CB-6329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978023#comment-13978023
]
ASF GitHub Bot commented on CB-6329:
------------------------------------
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-cli/pull/151#issuecomment-41141270
I've been working on some other stuff with cordova-mobile-spec, but I came
back to this topic to deliver the pending changes removing callback functions,
and use only promises and superspawn following the recommendations and feedback
provided.
Summary:
-Removed: All callbacks functions.
-Every function returns a promise.
-Use of superspawn instead of shelljs.
-Use of Q.defer(), to resolve or reject promises.
-Removed mostly all anonymous functions.
It's cleaner and complexity has been reduced without promises-callbacks
statements combination.
Q.allSettled it will wait until all promises are resolved, and then write
the log file, collecting all data.
@agrieve , thanks for the feedback and all the suggestions that you
provided me. If this is last commit is well accomplished, let me know to start
to work on add support for blackberry, wp8 and windows 8, using the same
pattern.
> [cordova-cli] improve 'cordova info' command to work asynchronous
> -----------------------------------------------------------------
>
> Key: CB-6329
> URL: https://issues.apache.org/jira/browse/CB-6329
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CLI
> Affects Versions: 3.4.0
> Reporter: Martin Gonzalez
> Assignee: Martin Gonzalez
> Labels: blackberry, cordova-cli, environment, info, wp8
> Fix For: 3.5.0
>
>
> The 'cordova info' command it works in total sync, it takes some time to pull
> and push all data from the environment, so in order to use callbacks more
> friendly, I'd like to modify the flow structure of the file and improve it to
> use get callback outputs, write summary or log file without templates.
> I also, I'd like to add a secondary file that holds all specific functions
> related with 'get information about the dev environment'.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
