[
https://issues.apache.org/jira/browse/CB-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978632#comment-13978632
]
ASF subversion and git services commented on CB-5105:
-----------------------------------------------------
Commit 90f115618a58ad942c5c97ae5534b6563cf38212 in cordova-plugin-device's
branch refs/heads/master from [~martin.c.glez.glez]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device.git;h=90f1156
]
CB-5105 Removed dead code for device.version
Dead code has been removed from the native side for the following
platforms:
-Android
-WP8
-BB10
-Windows 8
Every variable, method or argument related with retrieve the cordova
version from the native side has been removed. Given the fact that
cordova.js, it's providing the cordova.version.
The plugin has been tested under each platform involved with the
expected results, everything settled to be added to the repository.
github: close #13
> remove dead code for device.version from native plugin source
> -------------------------------------------------------------
>
> Key: CB-5105
> URL: https://issues.apache.org/jira/browse/CB-5105
> Project: Apache Cordova
> Issue Type: Improvement
> Components: Plugin Device
> Affects Versions: 3.1.0
> Reporter: Marcel Kinard
> Assignee: Martin Gonzalez
> Priority: Minor
>
> The solution for CB-5085 (and related) is for device.js to set device.cordova
> using CORDOVA_JS_BUILD_LABEL from cordova.js, instead of having native code
> do that (usually with hardcoded values) and return it back from exec(). So
> once CB-5085 is fixed in this way, then any native code that computes
> device.version is dead. That dead code should be removed from
> cordova-plugin-device, if for no other reason than reducing confusion.
> The following platforms are affected: Android, BB10, WP8, Win8.
> iOS is doing something special, but doing it right, so don't make any changes
> to iOS.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
