[
https://issues.apache.org/jira/browse/CB-6684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996937#comment-13996937
]
ASF GitHub Bot commented on CB-6684:
------------------------------------
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-windows/pull/30
CB-6684 [3.5.0rc][Windows8] Splash screen setting breaks the build
https://issues.apache.org/jira/browse/CB-6684
1. Copies image instead of changing reference - this is correct way since
img could be outside the project so it won't work (also, Windows8 splash screen
plugin requires default splash screen location)
2. Warns instead of build failure if splash screen reference is not a file
3. Fixed mixed tabs and spaces, all actual changes are under #Splash
screen support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-6684
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/30.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #30
----
commit d3dd1803aa7d8474aadbcb850ed0a572d23bb71a
Author: sgrebnov <[email protected]>
Date: 2014-05-13T21:40:16Z
CB-6684 [3.5.0rc][Windows8] Splash screen setting breaks the build
----
> [3.5.0rc][Windows8] Splash screen setting breaks the build
> ----------------------------------------------------------
>
> Key: CB-6684
> URL: https://issues.apache.org/jira/browse/CB-6684
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows 8
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
>
> Add dummy splash screen settings to config.xml
> <preference name="SplashScreen" value="screen" />
> Run build
> C:\temp\_rc3_5_0\app
> λ cordova build windows8
> Running command: C:\temp\_rc3_5_0\app\platforms\windows8\cordova\build.bat
> Building Cordova Windows 8 Project:
> Configuration : Debug
> Directory : C:\temp\_rc3_5_0\app\platforms\windows8
> MSBuildToolsPath: C:\Program Files (x86)\MSBuild\12.0\bin\
> cmd /c ""C:\Program Files (x86)\MSBuild\12.0\bin\msbuild"
> "C:\temp\_rc3_5_0\app\platforms\windows8\CordovaApp.sln"
> /clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal /nologo
> /p:Configuration=Debug"
> Building the projects in this solution one at a time. To enable parallel
> build, please add the "/m" switch.
> Applying Platform Config ...
> Setting SplashScreen = screen
> package.appxmanifest(20,31): error APPX1617: App manifest references the
> splash screen image 'screen' which has
> an unsupported extension. Extension must be JPG, JPEG, or PNG.
> [C:\temp\_rc3_5_0\app\platforms\windows8\CordovaApp.jsproj]
> Error: C:\temp\_rc3_5_0\app\platforms\windows8\cordova\build.bat: Command
> failed with exit code 2
> at ChildProcess.whenDone
> (C:\Users\Sergei\AppData\Roaming\npm\node_modules\cordova\node_modules\cordova-lib\src\cordova\superspawn.js:131:23)
> at ChildProcess.EventEmitter.emit (events.js:98:17)
> at maybeClose (child_process.js:743:16)
> at Process.ChildProcess._handle.onexit (child_process.js:810:5)
> We should check that file exists and if not then echo warning message instead
> of fail
--
This message was sent by Atlassian JIRA
(v6.2#6252)
