[
https://issues.apache.org/jira/browse/CB-6711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011174#comment-14011174
]
ASF GitHub Bot commented on CB-6711:
------------------------------------
Github user kamrik commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/15#discussion_r13135935
--- Diff: cordova-lib/src/plugman/util/config-changes.js ---
@@ -510,8 +509,7 @@ function ConfigFile_load() {
self.data = xml_helpers.parseElementtreeSync(filepath);
} else if (ext == '.pbxproj') {
self.type = 'pbxproj';
- self.data = xcode.project(filepath);
- self.data.parseSync();
+ self.data = platforms.ios.parseProjectFile(self.project_dir).xcode;
--- End diff --
It was part of a larger optimization to speed up "cordova prepare" during
which lots of files were re-parsed several times (once per plugin). Looks like
we introduced both changes at about the same time (Jan/Feb) this resulted in
double caching and overwriting. Before the two of our changes the extra glob
was executed per plugin during prepare and was one of the largest time wasters.
Anyway, right now the glob will only run once so it's not a big deal.
LGTM. Merging this PR.
> Adding multiple plugins for iOS is broken
> -----------------------------------------
>
> Key: CB-6711
> URL: https://issues.apache.org/jira/browse/CB-6711
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugman
> Reporter: Martin Bektchiev
> Assignee: Martin Bektchiev
>
> When adding multiple plugins for iOS projects framework config changes get
> overwritten.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
