[ 
https://issues.apache.org/jira/browse/CB-6909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vladimir Kotikov updated CB-6909:
---------------------------------

    Description: 
shellCmd and shellRunCmd are defined in master.cfg and used for a lot of the 
build tasks. But the value depends on the OS of the master, so if you have a OS 
X master and Windows client (or vice versa) a lot of steps will fail.
{noformat}
shellCmd="/bin/sh"
shellRunParam="-c"
if is_Windows :
    shellCmd="cmd"
    shellRunParam="/c"
{noformat}
For some steps, like in wp8 and windows8 sections, we know they'll always run 
on Windows so we could always use 'cmd'. But in common sections or for a 
platform like android, it needs to work on both.

-----

It seems that ShellCommand step already uses command interpreter according to 
slave platform (see 
http://docs.buildbot.net/current/manual/cfg-buildsteps.html#step-ShellCommand). 
So it's safe to remove this and specify commands for ShellCommand steps just 
with list of strings.

Another possible issue is different path delimiter on windows and other 
platforms. But in most cases slash instead of backslash works fine on windows. 
So it is possible to replace '\\' to '/' in windows build steps.

  was:
shellCmd and shellRunCmd are defined in master.cfg and used for a lot of the 
build tasks. But the value depends on the OS of the master, so if you have a OS 
X master and Windows client (or vice versa) a lot of steps will fail.

shellCmd="/bin/sh"
shellRunParam="-c"
if is_Windows :
    shellCmd="cmd"
    shellRunParam="/c"

For some steps, like in wp8 and windows8 sections, we know they'll always run 
on Windows so we could always use 'cmd'. But in common sections or for a 
platform like android, it needs to work on both.

It seems thst ShellCommand step already uses command interpreter that according 
to slave platform (see 
http://docs.buildbot.net/current/manual/cfg-buildsteps.html#step-ShellCommand)

So it's safe to remove this and specify commands for ShellCommand steps with 
list of strings.

Another possible issue is different path delimiter on windows and other 
platforms. But in most cases slash instead of backslash works fine on windows. 
So it is possible to replace '\\' to '/' in windows build steps.


> shellCmd and shellRunParam in master.cfg use values for master, fails on 
> Windows slaves if OS X master
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CB-6909
>                 URL: https://issues.apache.org/jira/browse/CB-6909
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Medic, Windows 8, WP8
>         Environment: OS X master, buildbot 0.8.8, Windows Server 2012R2 
> slave, buildslave 0.8.8
>            Reporter: Vladimir Kotikov
>            Assignee: Jesse MacFadyen
>              Labels: medic, windows8, wp8
>
> shellCmd and shellRunCmd are defined in master.cfg and used for a lot of the 
> build tasks. But the value depends on the OS of the master, so if you have a 
> OS X master and Windows client (or vice versa) a lot of steps will fail.
> {noformat}
> shellCmd="/bin/sh"
> shellRunParam="-c"
> if is_Windows :
>     shellCmd="cmd"
>     shellRunParam="/c"
> {noformat}
> For some steps, like in wp8 and windows8 sections, we know they'll always run 
> on Windows so we could always use 'cmd'. But in common sections or for a 
> platform like android, it needs to work on both.
> -----
> It seems that ShellCommand step already uses command interpreter according to 
> slave platform (see 
> http://docs.buildbot.net/current/manual/cfg-buildsteps.html#step-ShellCommand).
>  So it's safe to remove this and specify commands for ShellCommand steps just 
> with list of strings.
> Another possible issue is different path delimiter on windows and other 
> platforms. But in most cases slash instead of backslash works fine on 
> windows. So it is possible to replace '\\' to '/' in windows build steps.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to