[
https://issues.apache.org/jira/browse/CB-6970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036416#comment-14036416
]
ASF GitHub Bot commented on CB-6970:
------------------------------------
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/32#issuecomment-46496437
Thanks! This looks much cleaner.
> Share win project files manipulation code between cordova and plugman
> ---------------------------------------------------------------------
>
> Key: CB-6970
> URL: https://issues.apache.org/jira/browse/CB-6970
> Project: Apache Cordova
> Issue Type: Improvement
> Components: CordovaLib, Windows 8, WP8
> Reporter: Sergey Grebnov
> Assignee: Sergey Grebnov
> Labels: cordova-lib, windows8, wp8
>
> Both cordova and plugman use own logic to parse and modify jsproj and csproj
> files, for example (cordova) windows8_parser/update_jsproj and (plugman)
> w8jsproj.js/removeSourceFile use exactly the same code blocks to parse and
> update jsproj files.
> It is better to remove duplicate code and have special shared classes to work
> with project files. Cordova and plugman should rely on those classes instead
> of using own implementation.
> We should also remove manual project files manipulation logic from general
> cordova/plugman classes, like below.
> https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/plugman/prepare.js#L83
> Implementation layer should be hidden from them, they just need to rely on
> special well named methods provided by newly introduced classes (see above).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
