[
https://issues.apache.org/jira/browse/CB-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048006#comment-14048006
]
ASF GitHub Bot commented on CB-6949:
------------------------------------
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574133
> The pull request looks fine to me. My only suggestion would be to leave a
comment explaining that initialization must happen after cordova.js:
>
> // initialize the app after the cordova.js script so that deviceready is
registered.
> app.initialize();
I'm not sure this comment will be clear at this point. Maybe add something
to `index.html`, right before loading `js/index.js`? Although I don't think
this change really complicates this bit and the comment seems overkill.
> It would be nice to have an addition Mozillian verify that the change
solves CB-6949, before we merge the pull request.
I tested it and @zalun will take a look too.
> CSP in FirefoxOS breaks app.initialize() causing deviceReady not to fire
> ------------------------------------------------------------------------
>
> Key: CB-6949
> URL: https://issues.apache.org/jira/browse/CB-6949
> Project: Apache Cordova
> Issue Type: Bug
> Components: FirefoxOS
> Reporter: John McLear
> Priority: Critical
>
> To replicate:
> cordova create test
> cordova platform add firefoxos
> Run your application on firefoxos and you will notice deviceReady does not
> fire. You will also get a CSP warning.
> The cause is the inline "app.initialize()"
> The fix is to move the app.initialize() to another file and set the script at
> "defer"ed however I expect this will break a lot of other things.
> FirefoxOS expects CSP for all applications by default and is completely
> strict about certified applications.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
