[ 
https://issues.apache.org/jira/browse/CB-7067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054215#comment-14054215
 ] 

ASF GitHub Bot commented on CB-7067:
------------------------------------

Github user jsoref commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/51#discussion_r14625702
  
    --- Diff: cordova-lib/src/cordova/superspawn.js ---
    @@ -108,11 +108,17 @@ exports.spawn = function(cmd, args, opts) {
         if (child.stdout) {
             child.stdout.setEncoding('utf8');
             child.stdout.on('data', function(data) {
    +            if (opts && 'onstdout' in opts) {
    +                if (opts.onstdout(data)) { return; }
    +            }
                 capturedOut += data;
             });
     
             child.stderr.setEncoding('utf8');
             child.stderr.on('data', function(data) {
    +            if (opts && 'onstderr' in opts) {
    +                if (opts.onstdout(data)) { return; }
    --- End diff --
    
    yes, thanks


> run jasmine tests individually
> ------------------------------
>
>                 Key: CB-7067
>                 URL: https://issues.apache.org/jira/browse/CB-7067
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 3.5.0
>            Reporter: Josh Soref
>            Assignee: Josh Soref
>
> The way we run tests right now has a couple of painful points:
> 1. We can't skip only some tests in a single spec file because jasmine is 
> treating all of our tests as a single set run together, and so by saying "I 
> want to prefer test X in file A", it's interpreting that as "I don't want to 
> run any other tests in any other file unless they are also preferred". That's 
> pretty annoying.
> 2. Spys and other manipulations we do in a spec can have adverse impact on 
> unrelated tests. Trying to get tests to work thus involves debugging all 
> other tests and hunting for common problems.
> Neither of these things pain ports are necessary afaict.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to