[
https://issues.apache.org/jira/browse/CB-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054348#comment-14054348
]
ASF subversion and git services commented on CB-7091:
-----------------------------------------------------
Commit ab49973560ccb7a1ea37d9f5db4e497ef0ce92d1 in cordova-lib's branch
refs/heads/master from [~kamrik]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=ab49973 ]
CB-7091: Don't call check_requirements during platform add
check_reqs is called from the platform build script, there is no use in calling
it
twice.
Instead, added a simple check that if a platform has a list of compatible host
OSs (defined in platforms.js), the host OS is checked against this list.
> Remove check_requirements from cordova-lib
> ------------------------------------------
>
> Key: CB-7091
> URL: https://issues.apache.org/jira/browse/CB-7091
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
> Reporter: Mark Koudritsky
> Assignee: Mark Koudritsky
>
> As per this discussion [1] check_requirements() functions in platform parsers
> are redundant. The same check is executed twice, once via cordova create
> call_into_create() -> platform_parser ...
> and then again from the platform create script.
> Removing
> 1) The call to check_requriements() from create.js:call_into_create().
> 2) The check_requirements() functions from platform parsers in metadata.
> Adding:
> A simple check that the host OS is listed in platforms[platform].hostos
> [1] https://www.mail-archive.com/dev%40cordova.apache.org/msg19084.html
--
This message was sent by Atlassian JIRA
(v6.2#6252)
