[ 
https://issues.apache.org/jira/browse/CB-5109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14060627#comment-14060627
 ] 

Sergey Grebnov commented on CB-5109:
------------------------------------

Hi Maxime,
I've sent this via the following pull request, could you please review and let 
me know if it looks good to you.
https://github.com/apache/cordova-plugin-inappbrowser/pull/53

There were rebase conflicts so I had to include you work to my commit with 
special reference to your original work. Maxime, please let me know if this is 
ok. 
Iv'e also added the following changes:
1. (plugin.xml) Both Windows8 and Windows to reference to the same proxy class 
(previously there were proxy classes in src/ and www/)
2. Added required keepcallback = true parameter to navigation callbacks
3. Other super minor changes

Also tested for  Store 8.1 and Windows Phone 8.1. 



> Windows 8.1 - InAppBrowser
> --------------------------
>
>                 Key: CB-5109
>                 URL: https://issues.apache.org/jira/browse/CB-5109
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Plugin InAppBrowser, Windows 8
>            Reporter: Maxime LUCE
>            Assignee: Sergey Grebnov
>
> In Windows 8.1, there is a new WebView control.
> It can be used to create an InAppBrowser implementation.
> http://msdn.microsoft.com/en-us/library/windows/apps/dn301831.aspx



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to