[ 
https://issues.apache.org/jira/browse/CB-7000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shazron Abdullah updated CB-7000:
---------------------------------

    Description: 
// Deprecate these in favour of using CDVCommandDelegate directly.
// - (NSString*)writeJavascript:(NSString*)javascript;
// - (NSString*)success:(CDVPluginResult*)pluginResult 
callbackId:(NSString*)callbackId;
// - (NSString*)error:(CDVPluginResult*)pluginResult 
callbackId:(NSString*)callbackId;

These are remnants of how older plugins used pluginResult and are not doc'ed 
anymore since 3.x (it was in 2.x). Time to migrate people.

Also, CDVPluginResult corresponding methods should be removed as well:
https://github.com/apache/cordova-ios/blob/0bf656c3bccbe85813964bcf13c6705e0da37192/CordovaLib/Classes/CDVPluginResult.h#L63-L66

  was:
// Deprecate these in favour of using CDVCommandDelegate directly.
// - (NSString*)writeJavascript:(NSString*)javascript;
// - (NSString*)success:(CDVPluginResult*)pluginResult 
callbackId:(NSString*)callbackId;
// - (NSString*)error:(CDVPluginResult*)pluginResult 
callbackId:(NSString*)callbackId;

These are remnants of how older plugins used pluginResult and are not doc'ed 
anymore since 3.x (it was in 2.x). Time to migrate people.


> Remove deprecated CDVPlugin methods
> -----------------------------------
>
>                 Key: CB-7000
>                 URL: https://issues.apache.org/jira/browse/CB-7000
>             Project: Apache Cordova
>          Issue Type: Task
>          Components: iOS
>            Reporter: Shazron Abdullah
>
> // Deprecate these in favour of using CDVCommandDelegate directly.
> // - (NSString*)writeJavascript:(NSString*)javascript;
> // - (NSString*)success:(CDVPluginResult*)pluginResult 
> callbackId:(NSString*)callbackId;
> // - (NSString*)error:(CDVPluginResult*)pluginResult 
> callbackId:(NSString*)callbackId;
> These are remnants of how older plugins used pluginResult and are not doc'ed 
> anymore since 3.x (it was in 2.x). Time to migrate people.
> Also, CDVPluginResult corresponding methods should be removed as well:
> https://github.com/apache/cordova-ios/blob/0bf656c3bccbe85813964bcf13c6705e0da37192/CordovaLib/Classes/CDVPluginResult.h#L63-L66



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to