[
https://issues.apache.org/jira/browse/CB-7093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061162#comment-14061162
]
ASF GitHub Bot commented on CB-7093:
------------------------------------
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/60#issuecomment-48954105
The last commit on which is based is after this one:
https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=commit;h=005641907754e04895135e502ef9fcb6f24d353f
Made on 2014-06-23 by Martin Bektchiev- Fix failing battery tests. Add a
dummy battery listener
There's no file tests after that commit.
Based on some fixes that I've sent to mobile-spec.
https://github.com/apache/cordova-mobile-spec/pull/79
https://github.com/apache/cordova-mobile-spec/pull/75
By the way, your changes were good, I tried to remove most of the comments
and old content, some of them escaped from my sight, also it makes perfect
sense use URL instead of URI since is deprecated.
Ian, about the change that you made on plugin.xml, I think Andrew Grieve
point out that those changes would be made by adding some improvements to the
CLI, and avoid include tests in the release version of the plugin.
Check this comment on this PR.
https://github.com/apache/cordova-plugin-media-capture/pull/19
Thanks for taking this on, I'll be delivering the manual tests shortly.
Thanks @clelland
> Port automated file tests to plugin-test-framework
> --------------------------------------------------
>
> Key: CB-7093
> URL: https://issues.apache.org/jira/browse/CB-7093
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin File
> Affects Versions: 3.5.0
> Reporter: Martin Gonzalez
> Assignee: Martin Gonzalez
> Labels: plugin-file
> Fix For: 3.6.0
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
