[
https://issues.apache.org/jira/browse/CB-7124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065557#comment-14065557
]
ASF subversion and git services commented on CB-7124:
-----------------------------------------------------
Commit 0960eb1fcee5ff89fa84377ecb713c7fc3ca1991 in cordova-lib's branch
refs/heads/master from [~pascalw]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=0960eb1 ]
CB-7124 Wrap the cordova platform string in Platform object
This prevents having to duplicate the check whether the platform string
specifies a version or not.
github: close #61
> `cordova platform add <platform>@<version>` not working for Git based installs
> ------------------------------------------------------------------------------
>
> Key: CB-7124
> URL: https://issues.apache.org/jira/browse/CB-7124
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
> Affects Versions: 3.5.0
> Reporter: Pascal Widdershoven
>
> Currently the {{cordova platform add <platform>@<version>}} is only working
> with the {{--usenpm}} option enabled.
> I think --usenpm is disabled by default (\?) so this feature will appear
> broken to most users. I've pinpointed the problem to [this peace of
> code|https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/lazy_load.js#L86]
> where for the cordova_git function the @version check is missing, resulting
> in a "Platform not recognized" error when the platform includes a version
> code.
> I hope I can find some time to sign the ICLA and send a pull request. In
> general it seems that the whole @version check could be handled more
> elegantly, right now it's duplicated in several places making it easy to
> forget to add it somewhere.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
