[ 
https://issues.apache.org/jira/browse/CB-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071911#comment-14071911
 ] 

ASF GitHub Bot commented on CB-7186:
------------------------------------

Github user dylin commented on a diff in the pull request:

    https://github.com/apache/cordova-blackberry/pull/169#discussion_r15298452
  
    --- Diff: bin/templates/project/cordova/lib/cmdline.js ---
    @@ -30,7 +30,8 @@ command
         .option('-p, --params <params JSON file>', 'Specifies additional 
parameters to pass to downstream tools.')
         .option('--appdesc <filepath>', 'Optionally specifies the path to the 
bar descriptor file (bar-descriptor.xml). For internal use only.')
         .option('-v, --verbose', 'Turn on verbose messages')
    -    .option('-l, --loglevel <loglevel>', 'set the logging level (error, 
warn, verbose)');
    +    .option('-l, --loglevel <loglevel>', 'set the logging level (error, 
warn, verbose)')
    +    .option('--signing', 'if signing the app');
    --- End diff --
    
    cmdline.js not a command parser for end user, and end user won't see 
--signing in help message. cmdline.js parses arguments to packager, which 
inherits ww 1.0 packager.  and --signing is not a real argument to pass to 
packager, it's just a flag used by package-validate.js.  


> --no-signing will be ignored if --buildId is set
> ------------------------------------------------
>
>                 Key: CB-7186
>                 URL: https://issues.apache.org/jira/browse/CB-7186
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: BlackBerry
>    Affects Versions: 3.5.0
>            Reporter: Danyi Lin
>            Priority: Minor
>             Fix For: 3.6.0
>
>   Original Estimate: 1m
>  Remaining Estimate: 1m
>
> running command: build --release --buildId 123 --no-signing
> --no-signing will be ignored
> expect:
>  the bar file will be built without signing
> actual:
> the bar file was built with signing



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to