[ 
https://issues.apache.org/jira/browse/CB-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074820#comment-14074820
 ] 

ASF GitHub Bot commented on CB-7199:
------------------------------------

Github user purplecabbage commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/64#discussion_r15420741
  
    --- Diff: cordova-lib/src/cordova/lazy_load.js ---
    @@ -63,6 +63,7 @@ function Platform(platformString) {
             this.name = platformString;
             if (platforms[this.name]) this.version = 
platforms[this.name].version;
         }
    +    this.source = 'source' in platforms[this.name] ? 
platforms[this.name].source : 'npm';
    --- End diff --
    
    This broke the build: 
https://travis-ci.org/apache/cordova-lib/builds/30870405


> control git/npm using platform.js
> ---------------------------------
>
>                 Key: CB-7199
>                 URL: https://issues.apache.org/jira/browse/CB-7199
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaLib
>    Affects Versions: 3.6.0
>            Reporter: Josh Soref
>            Assignee: Josh Soref
>
> Currently the use of npm/git is hard coded to www = git; everything else = 
> npm or user knows how to use --usegit.
> That's a pain. especially for developing platforms. Instead, let's support 
> platforms.js controlling it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to