[
https://issues.apache.org/jira/browse/CB-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14077074#comment-14077074
]
ASF GitHub Bot commented on CB-4556:
------------------------------------
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-firefoxos/pull/18#discussion_r15496568
--- Diff: bin/templates/project/cordova/clean.bat ---
@@ -0,0 +1,27 @@
+:: Licensed to the Apache Software Foundation (ASF) under one
+:: or more contributor license agreements. See the NOTICE file
+:: distributed with this work for additional information
+:: regarding copyright ownership. The ASF licenses this file
+:: to you under the Apache License, Version 2.0 (the
+:: "License"); you may not use this file except in compliance
+:: with the License. You may obtain a copy of the License at
+::
+:: http://www.apache.org/licenses/LICENSE-2.0
+::
+:: Unless required by applicable law or agreed to in writing,
+:: software distributed under the License is distributed on an
+:: "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+:: KIND, either express or implied. See the License for the
+:: specific language governing permissions and limitations
+:: under the License.
+
+@ECHO OFF
+SET script_path="%~dp0clean"
+IF EXIST %script_path% (
+ node %script_path% %*
+ ECHO Cleaning Firefoxos project
--- End diff --
Our clean node script already outputs the same text, as you can see here:
https://github.com/apache/cordova-firefoxos/blob/master/bin/templates/project/cordova/lib/clean.js#L36
You can remove this ECHO. Everything else looks good and works great.
Thanks!
> Add a ./cordova/clean project-level script
> ------------------------------------------
>
> Key: CB-4556
> URL: https://issues.apache.org/jira/browse/CB-4556
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: FirefoxOS
> Reporter: Steve Gill
>
> This script should delete any build artifacts that are create from running an
> app compilation.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
