[ 
https://issues.apache.org/jira/browse/CB-7259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kia Thomas Fathi updated CB-7259:
---------------------------------

    Description: 
Platform: iOS
Plugin: org.apache.cordova.camera
Hardware: iphone 5

Strange behavior when selecting photos from library with camera.getPicture and 
cameraOptions with sourceType of Camera.PictureSourceType.PHOTOLIBRARY. 

Some photos rotate in unintuitive ways. I found that hardcoding 
correctOrientation to true in my cameraOptions argument fixed this problem.
 
This should be set to the default option, to save time for future developers 
who might encounter this behavior.

It is a pretty easy fix, specifically:

On line 58 of 
https://github.com/apache/cordova-plugin-camera/blob/master/www/Camera.js

Current:
  var correctOrientation = !!options.correctOrientation;

After-Fix:
        var correctOrientation = options.correctOrientation === undefined ? 
true : !!options.correctOrientation;


Pull Request: https://github.com/apache/cordova-plugin-camera/pull/41


  was:
Platform: iOS
Plugin: org.apache.cordova.camera
Hardware: iphone 5

Strange behavior when selecting photos from library with camera.getPicture and 
cameraOptions with sourceType of Camera.PictureSourceType.PHOTOLIBRARY. 

Some photos rotate in unintuitive ways. I found that hardcoding 
correctOrientation to true in my cameraOptions argument fixed this problem.
 
This should be set to the default option, to save time for future developers 
who might encounter this behavior.

It is a pretty easy fix, specifically:

On line 58 of 
https://github.com/apache/cordova-plugin-camera/blob/master/www/Camera.js

Current:
  var correctOrientation = !!options.correctOrientation;

After-Fix:
        var correctOrientation = options.correctOrientation === undefined ? 
true : !!options.correctOrientation;




> Camera Plugin defaults correctOrientation to false, more intuitive if default 
> = true.
> -------------------------------------------------------------------------------------
>
>                 Key: CB-7259
>                 URL: https://issues.apache.org/jira/browse/CB-7259
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Plugin Camera
>    Affects Versions: 3.5.0
>         Environment: This was observed on iOS. Specifically when selecting 
> images from PHOTOLIBRARY
>            Reporter: Kia Thomas Fathi
>            Priority: Minor
>              Labels: easyfix
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> Platform: iOS
> Plugin: org.apache.cordova.camera
> Hardware: iphone 5
> Strange behavior when selecting photos from library with camera.getPicture 
> and cameraOptions with sourceType of Camera.PictureSourceType.PHOTOLIBRARY. 
> Some photos rotate in unintuitive ways. I found that hardcoding 
> correctOrientation to true in my cameraOptions argument fixed this problem.
>  
> This should be set to the default option, to save time for future developers 
> who might encounter this behavior.
> It is a pretty easy fix, specifically:
> On line 58 of 
> https://github.com/apache/cordova-plugin-camera/blob/master/www/Camera.js
> Current:
>   var correctOrientation = !!options.correctOrientation;
> After-Fix:
>       var correctOrientation = options.correctOrientation === undefined ? 
> true : !!options.correctOrientation;
> Pull Request: https://github.com/apache/cordova-plugin-camera/pull/41



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to