[ 
https://issues.apache.org/jira/browse/CB-7240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089535#comment-14089535
 ] 

Martin Gonzalez commented on CB-7240:
-------------------------------------

Hey Mark, I have solved the issue properly linking the cordova-lib from master 
to cli from master.
It didn't worked one day, and then it worked on the other day, kind of weird.
Some concerns & questions about this:

I think that the master branch should be working stable and working by just 
type "npm install", it just seems like an extra burden, get to clone 
cordova-lib, then install it, then link it to the CLI node modules.

Well even so, the package.json on the CLI points to a cordova-lib that it may 
not be fully compatible with CLI on master.
In that case, it would be better remove cordova-lib dependency from the 
package.json, to force the user-dev to get the right cordova-lib, install it 
and link it, in order to make it work.
Have you consider the possibility to work in a different branch and publish 
into master, only when the proper and fully compatible "cordova-lib" is 
released to npm, and available to use?

Well, I have solved the problem as I explained, just have those questions above.

Thanks.

> Cordova-cli breaking changes on master
> --------------------------------------
>
>                 Key: CB-7240
>                 URL: https://issues.apache.org/jira/browse/CB-7240
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CLI, CordovaLib
>    Affects Versions: 3.6.0
>         Environment: Windows 7, 64 bit.
> NodeJS v0.10.28
>            Reporter: Martin Gonzalez
>              Labels: CLI, cordova-lib
>             Fix For: 3.6.0
>
>
> I have notice that the latest changes on cordova-cli master branch, are not 
> working properly when --link-to is used for custom www resources.
> It throws a error on the module:
> cordova-cli\bin\cordova create test --link-to cordova-mobile-spec\www
> Creating a new cordova project with name "HelloCordova" and id 
> "io.cordova.hello
> cordova" at location "C:\Users\Administrator\MobileSpecTests_New\test"
> Using custom www assets from undefined
> TypeError: Arguments to path.resolve must be strings
>     at Object.exports.resolve (path.js:116:15)
>     at Object.exports.relative (path.js:239:20)
>     at Object.create 
> (C:\Users\Administrator\MobileSpecTests_New\cordova-cli\nod
> e_modules\cordova-lib\src\cordova\create.js:108:56)
>     at cli 
> (C:\Users\Administrator\MobileSpecTests_New\cordova-cli\src\cli.js:23
> 8:21)
>     at Object.<anonymous> 
> (C:\Users\Administrator\MobileSpecTests_New\cordova-cl
> i\bin\cordova:41:1)
>     at Module._compile (module.js:456:26)
>     at Object.Module._extensions..js (module.js:474:10)
>     at Module.load (module.js:356:32)
>     at Function.Module._load (module.js:312:12)
>     at Function.Module.runMain (module.js:497:10)
> The branch that is working properly is :rb_3.5.0-0.2.6, on that branch 
> there's no problem at all, at least with --link-to.
> CLI on master branch is using "cordova-lib 21.6", as well as rb_3.5.0-0.2.6 
> branch, so the problem should in the CLI and not in the cordova-lib.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to