[ 
https://issues.apache.org/jira/browse/CB-7092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094912#comment-14094912
 ] 

ASF subversion and git services commented on CB-7092:
-----------------------------------------------------

Commit 3317891cc7e2071a6e0ab81f223e2a9210ebb66f in cordova-plugin-media's 
branch refs/heads/master from [~martin.c.glez.glez]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-media.git;h=3317891 ]

CB-6963 Port Media manual & automated tests

Ported 17 Media automated & manual tests from mobilespec.

This commit adds the work done by javierbb31

Jasmine version: ported from v1.3 to v2.0

Features(automated tests):
-No spies.
-Tests failing faster, when a error callback or unexpected success
callback is received, the test fails immediately.
-Jasmine report with more information about the failed operation, which
contains the operation and a description about it.
-Jasmine reports include error callback object.
-Two timeout statement to just wait until the a media file is
reproduced, there are no more timeouts than those.
-Added a control variable to ensure that a callback is reached only
once.

Bugs:
There are two bugs reported as direct result of this porting activity.

CB-7092

https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L158

This one it's about a conditional added in case that the platform is
windows phone, on that platform it has an unexpected behavior at the
error callback. If the platform is windows phone the test is going to
fail, until the bug is fixed, this specific problem causes a mess with
the rest of the test.
All details related to this:
https://issues.apache.org/jira/browse/CB-7092

CB-7099

https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L188

https://github.com/martincgg/cordova-plugin-media/blob/9fab60a8a3de2b68cb96fdcdd36cbdbfff73ce8e/test/tests.js#L215


> [WP8][cordova-plugin-media] it gets multiple times to error callback, when an 
> invalid file name is provided
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: CB-7092
>                 URL: https://issues.apache.org/jira/browse/CB-7092
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin Media, WP8
>    Affects Versions: 3.5.0
>            Reporter: Martin Gonzalez
>            Assignee: Jesse MacFadyen
>              Labels: WP8, media
>             Fix For: 3.6.0
>
>
> When an invalid file name is provided to create a new Media object, the error 
> callback it goes crazy, throwing the same error multiple times and getting to 
> the same callback multiple times instead of one error notification or 
> walk-through.
> E.g:
> badMedia = new Media("invalid.file.name", callback, errorcallack);
> It gets stuck in errorcallback for some time, before move on.
> Found porting mobilespec test to new plugin test framework, this behavior it 
> was found trying to use the error callback object to complete the test, 
> instead of set a timeout to determine if that callback it was called or not.
> This behavior it can be only reproduced under Windows Phone 8.
> Android works pretty fine, and without this issue.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to