[
https://issues.apache.org/jira/browse/CB-7131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095546#comment-14095546
]
ASF GitHub Bot commented on CB-7131:
------------------------------------
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/39#discussion_r16179759
--- Diff: src/android/ContactAccessorSdk5.java ---
@@ -436,7 +436,10 @@ else if
(mimetype.equals(ContactsContract.CommonDataKinds.Event.CONTENT_ITEM_TYP
}
else if
(mimetype.equals(ContactsContract.CommonDataKinds.Photo.CONTENT_ITEM_TYPE)
&& isRequired("photos", populate)) {
- photos.put(photoQuery(c, contactId));
+ JSONObject photo = photoQuery(c, contactId);
+ if (photo != null) {
+ photos.put(photo);
--- End diff --
this is probably under indented (2 space instead of 4 space)
> Contact picker returns photo url even if a contact doesn't have one. (Android
> 4.4.4, 4.3)
> -----------------------------------------------------------------------------------------
>
> Key: CB-7131
> URL: https://issues.apache.org/jira/browse/CB-7131
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin Contacts
> Affects Versions: 3.5.0
> Reporter: Meshkov Alex
> Assignee: Sergey Grebnov
> Priority: Minor
>
> When I pick contact that doesn't have any avatar with
> {code}navigator.contacts.pickContact{code} I get contact object with photo
> url which is broken. Contact without avatar should not contain any photo
> urls, but somehow it does...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
