[ 
https://issues.apache.org/jira/browse/CB-7350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104807#comment-14104807
 ] 

ASF GitHub Bot commented on CB-7350:
------------------------------------

GitHub user jsoref opened a pull request:

    https://github.com/apache/cordova-mobile-spec/pull/103

    CB-7350 Make createmobilespec friendlier

    Unlike the other pull requests of late, I do plan to squash these (and 
write a better commit message).
    
    They're split up here for review... The best way to review them is:
    ```sh
    git log --oneline --decorate -w -p master..FETCH_HEAD
    ```
    
    apache/cordova-js#78 will help with one of the other items (cordova-js has 
grown some dependencies, and users aren't likely to have run npm install)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jsoref/cordova-mobile-spec docwork

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-mobile-spec/pull/103.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #103
    
----
commit e0cf43f6ef07f9fadc3c5fb33284de5963324f80
Author: Josh Soref <[email protected]>
Date:   2014-08-20T21:08:40Z

    Improve README.md markdown
    
    Also annotate points where I think the content is wrong

commit fbee67619dd44696203f61d9a299c3b283c023a0
Author: Josh Soref <[email protected]>
Date:   2014-08-20T21:09:00Z

    Remove trailing whitespace

commit 8abdb4ec1c98c674b18fecdac91e7a1022a7da27
Author: Josh Soref <[email protected]>
Date:   2014-08-20T21:09:30Z

    Correct __dirname referenced paths

commit 494632fed76f146122e2c1f62edb9d99df607d6d
Author: Josh Soref <[email protected]>
Date:   2014-08-20T21:10:13Z

    Comment out nonsense claim about consumers
    
    Most consumers of this are testers, not developers

commit e281014b4614da42404e56d0d09c5bc1d01ef9ba
Author: Josh Soref <[email protected]>
Date:   2014-08-20T21:10:45Z

    Explain how to get coho

commit 11498c9cf8ac80c3e2222bd75b6cffe2e107ed84
Author: Josh Soref <[email protected]>
Date:   2014-08-20T21:11:10Z

    Fix instructions for getting cli+lib and plugins

commit 4dc85564ca3b9a524965ec432173f52e8a788503
Author: Josh Soref <[email protected]>
Date:   2014-08-20T22:08:52Z

    Add quietshell pushd/popd

commit 423d36e44cc7c9f7b84dc9b0d31b435929b56f67
Author: Josh Soref <[email protected]>
Date:   2014-08-20T22:23:51Z

    support debug logging level

commit 851241d6a5c21ba16ff31271ddc32d04376412d9
Author: Josh Soref <[email protected]>
Date:   2014-08-20T22:31:32Z

    quit instead of return in top level code...

commit 6536d2225ea67f2cc608a5d9a9777fca43bd802b
Author: Josh Soref <[email protected]>
Date:   2014-08-20T23:08:08Z

    Skip broken platforms

commit c5baa3978a0ab964101250d4aacd15551f8b7e87
Author: Josh Soref <[email protected]>
Date:   2014-08-20T23:12:42Z

    Refactor installPlugins, updateJS, summary
    
    Only call them if there are platforms left

commit 54f0b41632e5f4b073aaf012a0d19110dac95434
Author: Josh Soref <[email protected]>
Date:   2014-08-20T23:17:57Z

    Add could not find routine with coho instructions

commit 7569a98a4bc4ec6cdd8951226f5ffb7ab283d02d
Author: Josh Soref <[email protected]>
Date:   2014-08-20T23:20:55Z

    Require grunt-cli

----


> Make createmobilespec friendlier
> --------------------------------
>
>                 Key: CB-7350
>                 URL: https://issues.apache.org/jira/browse/CB-7350
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: mobile-spec
>    Affects Versions: 3.5.0
>            Reporter: Josh Soref
>            Assignee: Josh Soref
>
> * Don't assume that the people running mobilespec are developers -- In my 
> experience, they aren't
> * The READMEs needed a refresh
> * Asking people to install grunt-cli globally is silly, we have npm 
> dependencies, we can use them.
> * The pushd/popd spam is really not helpful afaict
> * Provide information about how to use coho to get the right things more or 
> less at the right time
> * Fix the __dirname output to be correct
> ... some other stuff...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to