[ 
https://issues.apache.org/jira/browse/CB-7415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112587#comment-14112587
 ] 

ASF GitHub Bot commented on CB-7415:
------------------------------------

GitHub user dzeims opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/71

    Possible fix for CB-7415: Implement a more feature complete implementation 
of ProgressEvent

    * Reuse native ProgressEvent if supported
    * Partially or completely pollyfill ProgressEvent if required
    * Support assigning the target event property via the event dictionary 
(needed by File plugin's FileReader/FileWriter.js)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dzeims/cordova-plugin-file master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/71.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #71
    
----
commit 0b5013c3d4d1942263c54985cef96b8b99a63266
Author: James White <[email protected]>
Date:   2014-08-27T18:00:15Z

    Implement a more feature complete implementation of ProgressEvent
    * Reuse native ProgressEvent if supported
    * Partially or completely pollyfill ProgressEvent if required
    * Support assigning the target event property via the event dictionary 
(needed by File plugin's FileReader/FileWriter.js)

----


> File plugin's ProgressEvent implementation overwrites browser's native 
> implementation
> -------------------------------------------------------------------------------------
>
>                 Key: CB-7415
>                 URL: https://issues.apache.org/jira/browse/CB-7415
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File
>    Affects Versions: 3.5.0
>            Reporter: James White
>
> The File plugin includes ProgressEvent.js, an implementation that mimics 
> ProgressEvent objects for the FileReader/FileWriter objects, but does not 
> include the usual event methods, etc.  
> When the File plugin is added to a project, any existing ProgressEvent 
> implementation native to the browser environment is overwritten with this 
> one, breaking code outside of the plugin that relies on ProgressEvent 
> functionality.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to