[
https://issues.apache.org/jira/browse/CB-7417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112957#comment-14112957
]
ASF GitHub Bot commented on CB-7417:
------------------------------------
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/72
[CB-7417][File tests] added proper matcher to compare fullPath property
Specs : 111, 112 & 121-124, were using [toBe, toEqual] to compare a Entry's
fullPath property.
The right matcher to use is toCanonicallyMatch, that it makes a fair and
right comparison across platforms.
In addition, special case to compare Windows Phone entries, was removed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-plugin-file CB-7417
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit b15778749f7487cc4a8fb66c33a86a1a48594430
Author: Martin Gonzalez <[email protected]>
Date: 2014-08-27T22:20:43Z
[CB-7417][File tests] added proper matcher to compare fullPath property
Specs : 111, 112 & 121-124, were using [toBe, toEqual] to compare a
fullPath property from an Entry.
The right matcher to use is toCanonicallyMatch, that it makes a fair and
right comparison across platforms.
In addition, special case to compare Windows Phone entries, was removed.
----
> [File tests] use proper matcher to compare fullPath property
> ------------------------------------------------------------
>
> Key: CB-7417
> URL: https://issues.apache.org/jira/browse/CB-7417
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
> Affects Versions: 3.5.0
> Reporter: Martin Gonzalez
> Assignee: Martin Gonzalez
> Priority: Minor
> Labels: mobilespec, plugin-file
> Fix For: 3.6.0
>
>
> Specs : 111, 112 & 121-124 are not comparing rightfully, the usage of
> toCanonicallyMatch custom matcher would bring a fair comparison across
> platforms.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
