[
https://issues.apache.org/jira/browse/CB-7375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113931#comment-14113931
]
ASF GitHub Bot commented on CB-7375:
------------------------------------
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/75
[CB-7375] Remove leading slash statement from condition
Windows Phone file paths starts with a leading slash, if the path is an
invalid one, the native side it will report a error callback with the
respective error code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-plugin-file CB-7375
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit 36134d48c1864278eb99add9db5a7ca8a4445f74
Author: Martin Gonzalez <[email protected]>
Date: 2014-08-28T16:26:24Z
[CB-7375] Remove leading slash statement from condition
Windows Phone file paths starts with a leading slash, if the path is an
invalid one, the native side it will report a error callback with the
respective error code.
----
> Investigate breaking changes at file plugin
> -------------------------------------------
>
> Key: CB-7375
> URL: https://issues.apache.org/jira/browse/CB-7375
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File
> Affects Versions: 3.5.0
> Reporter: Martin Gonzalez
> Labels: file
> Fix For: 3.6.0
>
> Attachments: Jasmine-Report-File&MediaPlugin-tests_149-30-1.txt
>
>
> Some of the changes made lately to file plugin with this commit:
> https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;a=commit;h=0ffb96988c0539222887f7756a653e7f0a1ed12c
> Are breaking changes to this plugin, affecting other platforms as android.
> Running mobile spec after that specific commit, 4 file tests are failing
> (test 125 -128).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
