[
https://issues.apache.org/jira/browse/CB-7216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114046#comment-14114046
]
ASF GitHub Bot commented on CB-7216:
------------------------------------
GitHub user stacic opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/21
CB-7216 API audit for vibration on wp8
Added support for:
- cancelVibration (including vibration with pattern)
- vibrateWithPattern
- truncation of vibration when argument is > 5seconds on wp (formerly
exception was thrown)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stacic/cordova-plugin-vibration CB-7216
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-vibration/pull/21.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21
----
commit faa3d626d8f941273b8edadeb48f7f30af198a53
Author: Staci Cooper <[email protected]>
Date: 2014-07-29T15:08:33Z
CB-6914 added cancelVibration for wp8
commit 7dd0e6610be372b076daf6f6c80f4ec3aa5e0df4
Author: Staci Cooper <[email protected]>
Date: 2014-07-29T15:24:43Z
CB-6916 added vibrateWithPattern for wp8
Also change to cancelVibration to allow for canceling a pattern
commit 6899790d10a951a858dd1bb2df0df20d0e010d26
Author: Staci Cooper <[email protected]>
Date: 2014-07-29T15:36:48Z
CB-7218 truncate vibration to 5 secs for WP8
wp8 throws an error if given timespan > 5 secs for vibration. It should
truncate the vibration instead.
commit 463dbfa9c5f69dc2f1ec6c2b1a8c5b2664d051a1
Author: Staci Cooper <[email protected]>
Date: 2014-08-25T16:03:26Z
Merge branch 'master' of
https://git-wip-us.apache.org/repos/asf/cordova-plugin-vibration into CB-7216
commit 6612805e61dba39ea638c6801ff4e11163fa0d70
Author: Staci Cooper <[email protected]>
Date: 2014-08-28T17:42:06Z
CB-7216 changed cancelWasCalled boolean
- changed variable name
- clear at the beginning of call to vibrateWithPattern
----
> Vibration - align with w3c spec WP8
> -----------------------------------
>
> Key: CB-7216
> URL: https://issues.apache.org/jira/browse/CB-7216
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Plugin Vibration, WP8
> Reporter: Staci Cooper
> Assignee: Staci Cooper
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
