[
https://issues.apache.org/jira/browse/CB-7422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114500#comment-14114500
]
ASF GitHub Bot commented on CB-7422:
------------------------------------
GitHub user martincgg opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/77
[CB-7422][File Tests] Use proper fileSystem to create fullPath
The filesystem uses root filesystem (PERSISTENT) to compare with a
TEMPORARY filesystem.
This is wrong, if TEMPORARY, var 'temp_root' should be used to assign value
to fullPath.
Tested over android & WP8, everything OK.
This wasn't caught before, because android :
fullPath is: /file, and (root.fullPath + file) returns ---> /file.
although for Windows Phone: the fullPath provides the nativePath as
/tmp//file, when it tries to compare with (root.fullPath + file) gives //file.
But tmp_root.fullPath provides the right path: /tmp/ to compare with.
Android it doesn't provide any different fullPath property if temporary or
persistent, the right path it's contained over the Native or Internal path.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martincgg/cordova-plugin-file CB-7422
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file/pull/77.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #77
----
commit 690cbdf3edf2daf273bd7d18ce51e0b9cc76b8c1
Author: Martin Gonzalez <martin.c.glez.g...@gmail.com>
Date: 2014-08-28T22:18:34Z
[CB-7422][File Tests] Use proper fileSystem to create fullPath
The filesystem uses root filesystem (PERSISTENT) to compare with a
TEMPORARY filesystem.
This is wrong, if TEMPORARY, temp_root, should be used to assign value
to fullPath.
----
> [File tests][126 & 128] use proper filesystem to compare with
> -------------------------------------------------------------
>
> Key: CB-7422
> URL: https://issues.apache.org/jira/browse/CB-7422
> Project: Apache Cordova
> Issue Type: Bug
> Components: mobile-spec, Plugin File
> Affects Versions: 3.5.0
> Reporter: Martin Gonzalez
> Assignee: Martin Gonzalez
> Priority: Minor
> Labels: mobilespec, plugin-file
> Fix For: 3.6.0
>
>
> Specs 126 & 128, are trying to compare against a fullPath that it supposed to
> canonically match with the provided one, although the entry it has to be
> located over the 'TEMPORARY' file system, but the fullPath variable to
> compare against the entry.fullVariable, it's created using the root or
> 'PERSISTENT' fileSystem.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
