[
https://issues.apache.org/jira/browse/CB-7430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116529#comment-14116529
]
Patrick Mueller commented on CB-7430:
-------------------------------------
I've decided to create a more elaborate patch to remove CoffeeScript as a
runtime dependency; it's in devDependencies now, and the build script will
recompile the .coffee files into .js files. One less thing to de-dupe.
Also upgraded the coffee-script, nopt and underscore versions in the
package.json.template file to recent versions. Express has changed so much I
decided to not upgrade to it's major version - but there has been a patch
version since the last release that shows up here.
This is currently in a branch CB-7430, per:
https://github.com/apache/cordova-weinre/tree/CB-7430
https://git-wip-us.apache.org/repos/asf?p=cordova-weinre.git;a=shortlog;h=refs/heads/CB-7430
all in this commit:
https://github.com/apache/cordova-weinre/commit/9b06777d6b23d1d2785b66a0e3f6f6c754561a08
https://git-wip-us.apache.org/repos/asf?p=cordova-weinre.git;a=commit;h=9b06777d6b23d1d2785b66a0e3f6f6c754561a08
I'll merge it in a few days, give you a chance to try it if you like.
> weinre does not play nice with npm dedupe
> -----------------------------------------
>
> Key: CB-7430
> URL: https://issues.apache.org/jira/browse/CB-7430
> Project: Apache Cordova
> Issue Type: Bug
> Components: weinre
> Affects Versions: 2.0.0
> Environment: Ubuntu, node.js 0.10.31
> Reporter: Magnus Skog
> Assignee: Patrick Mueller
> Priority: Minor
> Labels: node.js, npm
>
> Weinre breaks if you dedupe your node dependencies. This happens because
> weinre assumes that coffee-script is located in the local node_modules
> folder, which might not be the case after npm dedupe.
> Error: Cannot find module
> '/Users/erikn/Code/eagle-ng/node_modules/grunt-weinre/node_modules/weinre/node_modules/coffee-script'
> at Function.Module._resolveFilename (module.js:338:15)
> at Function.Module._load (module.js:280:25)
> at Module.require (module.js:364:17)
> at require (module.js:380:17)
> at Object.<anonymous>
> (/Users/erikn/Code/eagle-ng/node_modules/grunt-weinre/node_modules/weinre/weinre:34:1)
> at Module._compile (module.js:456:26)
> at Object.Module._extensions..js (module.js:474:10)
> at Module.load (module.js:356:32)
> at Function.Module._load (module.js:312:12)
> at Function.Module.runMain (module.js:497:10)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
