[
https://issues.apache.org/jira/browse/CB-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126741#comment-14126741
]
ASF GitHub Bot commented on CB-7494:
------------------------------------
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/44#discussion_r17287461
--- Diff: windows/bin/lib/create.js ---
@@ -66,8 +68,8 @@ module.exports.run = function (argv) {
["package.windows.appxmanifest", "package.windows80.appxmanifest",
"package.phone.appxmanifest"].forEach(function (file) {
var fileToReplace = path.join(projectPath, file);
shell.sed('-i', /\$guid1\$/g, guid, fileToReplace);
- shell.sed('-i', /\$safeprojectname\$/g, safeAppName,
fileToReplace);
- shell.sed('-i', /\$projectname\$/g, packageName, fileToReplace);
+ shell.sed('-i', /\$safeprojectname\$/g, packageName,
fileToReplace);
--- End diff --
Vladimir, could you please also file separate issue to correct placeholders
names; looks like
$(safe)projectname is actually a package name. I would refine those names
moving forward
> cordova-windows fails to build app with unicode name using cordova/build.bat
> script
> -----------------------------------------------------------------------------------
>
> Key: CB-7494
> URL: https://issues.apache.org/jira/browse/CB-7494
> Project: Apache Cordova
> Issue Type: Bug
> Components: Windows
> Reporter: Vladimir Kotikov
>
> Repro steps (in cordova-windows repo):
> {{windows\bin\create "testcreate 応用" com.test.app 応用}}
> {{".windows\testcreate 応用\cordova\build"}}
> Expected:
> App builds successfully.
> Actual:
> {noformat}
> package.windows80.appxmanifest(35,22): error APPX3032: App manifest
> validation failed.
> Value '応用' of attribute '/Package/Applications/Application/@Id' is n ot a
> valid ASCII Windows ID.
> It must contain one or more parts, separated with periods, where each part
> contains only characters a-z, A-Z, 0-9, and does no t start with a digit.
> [d:\cordova\cordova-windows\windows\testcreate 応用\CordovaApp.Windows80.jsproj]
> {noformat}
> This doesn't affects CLI
> The reason is that bin/create script write app name and app id in wrong
> places at *.manifest files
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
