[ 
https://issues.apache.org/jira/browse/CB-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137321#comment-14137321
 ] 

ASF GitHub Bot commented on CB-7487:
------------------------------------

Github user clelland commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/81#discussion_r17667021
  
    --- Diff: src/android/LocalFilesystem.java ---
    @@ -589,6 +593,32 @@ public long writeToFileAtURL(LocalFilesystemURL 
inputURL, String data,
     
             return rawData.length;
        }
    +   
    +    /**
    +     * Send broadcast of new file so files appear over MTP
    +     *
    +     * @param inputURL
    +     */
    +   private void broadcastNewFile(LocalFilesystemURL inputURL) {
    +           //Get the activity
    +           Activity activity = this.cordova.getActivity();
    +           
    +           //Get the context
    +           Context context = activity.getApplicationContext();
    +           
    +           //Get file
    +           File file = new File(this.filesystemPathForURL(inputURL));
    +           if (file != null) {
    --- End diff --
    
    What is this comparison for? I'm pretty sure that `new` can't ever return 
`null`. It also doesn't check for file existence; you'd want `file.exists()` 
for that.


> Writing a file doesn't show up on android MTP
> ---------------------------------------------
>
>                 Key: CB-7487
>                 URL: https://issues.apache.org/jira/browse/CB-7487
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin File
>    Affects Versions: 3.4.0
>         Environment: Nexus 5 and Windows 7
>            Reporter: David Peacock
>            Assignee: Ian Clelland
>
> Using the file plug-in to write out a file works, but when you use MTP to 
> view the file when connected to USB on Windows the file doesn't show up.  
> The file shows up on the device or through adb.  Rebooting the device or 
> using things to refresh the MTP will have the file appear.  This was tested 
> on multiple Nexus 5 devices on multiple Windows 7 machines.
> Cordova should be broadcasting ACTION_MEDIA_SCANNER_SCAN_FILE on the file to 
> have it appear immediately.
> I will be submitting a pull request on the file plug-in for a fix I've tested 
> and confirmed that resolves this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to