[
https://issues.apache.org/jira/browse/CB-7639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148843#comment-14148843
]
ASF GitHub Bot commented on CB-7639:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/35
CB-7639 Notification.confirm() fails on windows due to multiple issues
Fixes for multiple issues described in
https://issues.apache.org/jira/browse/CB-7639
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-dialogs CB-7639
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-dialogs/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit d806eed27b303601f232af8ceed16d9fa9af24fa
Author: Vladimir Kotikov <[email protected]>
Date: 2014-09-25T13:04:33Z
CB-7639 Handle button labels as array on windows
commit eb756c2dce47ae0f8d1b00dcb8ff3bcc1f842baf
Author: Vladimir Kotikov <[email protected]>
Date: 2014-09-25T13:18:18Z
CB-7639 Revert back isAlertShowing flag in case of exception to prevent
queuing of future dialogs.
commit d8e7d751b3371e4f12da99a4163c4bb61d48e5cd
Author: Vladimir Kotikov <[email protected]>
Date: 2014-09-25T13:21:54Z
CB-7639 Update docs + manual tests
----
> Notification.confirm() fails on windows due to multiple issues
> --------------------------------------------------------------
>
> Key: CB-7639
> URL: https://issues.apache.org/jira/browse/CB-7639
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Dialogs
> Reporter: Vladimir Kotikov
>
> There are bunch of issues related to this bug:
> # On WP8.1 it's not possible to show dialog with more than two buttons. Such
> attempt will cause {{WinRTError: The parameter is incorrect}} exception
> # On Windows8/8.1 it is not possible to add more than three buttons to
> MessageDialog instance. It will throw {{JavaScript runtime error: The
> operation attempted to access data outside the valid range}} error.
> These issues should be noted in plugin's docs.
> # After dialog call, that causes any exception such as listed above,
> following attempts to show any dialog will have no effect because of
> windows's implementation logic. We need to handle exceptions inside of plugin
> and always set {{isAlertShowing}} flag to false to prevent queuing of future
> dialogs calls.
> # When confirm dialog is called with buttons array, if one of button's labels
> contains a comma, it will be splitted to two separate labels. For example
> {{["yes","no","maybe,possible"]}} will be converted into
> {{["yes","no","maybe", "possible"]}}
> Also there is issue in manual tests: windows Javascript apps doesn't have
> built-in notification finctions, such as {{alert()}} or {{confirm()}}, so
> manual tests that calls this methods will fail. We need to add check for
> these methods exists to manual tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
