[ 
https://issues.apache.org/jira/browse/CB-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151638#comment-14151638
 ] 

ASF GitHub Bot commented on CB-7656:
------------------------------------

GitHub user vladimir-kotikov opened a pull request:

    https://github.com/apache/cordova-windows/pull/49

    CB-7656 Fixes list-devices and list-emulators commands

    Fix for https://issues.apache.org/jira/browse/CB-7656

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-windows CB-7656

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #49
    
----
commit 96e24cbb2c7bde68ffa3e452511ca2162bd1ec75
Author: Vladimir Kotikov <[email protected]>
Date:   2014-09-29T09:20:33Z

    Fixes list-devices and list-emulators commands

----


> cordova/lib/list-devices script is faulty on Windows
> ----------------------------------------------------
>
>                 Key: CB-7656
>                 URL: https://issues.apache.org/jira/browse/CB-7656
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Windows
>    Affects Versions: 3.6.3
>            Reporter: Vladimir Kotikov
>            Priority: Minor
>              Labels: list-devices, list-emulators,, windows,
>             Fix For: 3.7.0
>
>
> When trying to run 'cordova/lib/list-devices.bat' script from windows 
> platform directory, getting following error:
> {noformat}
> d:\cordova\mobile spec>platforms\windows\cordova\lib\list-devices.bat
> [eval]:1 
> require('./d:\cordova\mobile 
>         ^^^^^^^^^^^^^^^^^^^^ 
> SyntaxError: Unexpected token ILLEGAL 
>     at Object.<anonymous> ([eval]-wrapper:6:22) 
>     at Module._compile (module.js:456:26) 
>     at evalScript (node.js:536:25) 
>     at startup (node.js:80:7) 
>     at node.js:906:3 
> {noformat}
> Cause is that script's path environment variable is not expanded correctly 
> while running inline NodeJS script.
> Solution is to place JS logic into standalone JS file (use wp8 platform as 
> sample).
> list-emulator-images and list-started-emulators commands also can be ported 
> from wp8 tooling to preserve code consistency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to