[
https://issues.apache.org/jira/browse/CB-7674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154045#comment-14154045
]
Martin Gonzalez commented on CB-7674:
-------------------------------------
Changes look good.
I've tested the changes using mobilespec, and also android native tests,
everything looks good(Android 4.4.2). This changes solves the problem that
we've been facing and also this major change on the API.
> Preference activation no longer occurs in CordovaActivity.onCreate()
> --------------------------------------------------------------------
>
> Key: CB-7674
> URL: https://issues.apache.org/jira/browse/CB-7674
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android
> Affects Versions: 3.6.0
> Reporter: Marcel Kinard
> Assignee: Marcel Kinard
> Priority: Blocker
>
> During the 3.6.0 development timeframe, a modification was made to
> CordovaActivity.onCreate() to move the activation of preferences to
> CordovaActivity.init(). For applications that were relying on the activation
> of preferences in onCreate(), those preferences are no longer active when
> onCreate() completes, and may break those applications. Although it is
> described as a "subtle change to the API surface" in the commit message, this
> is a breaking change to a public API.
> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=705991e5b037743e632934b3c6ee98976e18d3f8
> https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commitdiff;h=a14c7942557fbaea41438bd3fe104b47997d8371;hp=aef96e95e82545a2321d798b469ec7fe60f72803
> http://callback-dev.markmail.org/thread/gcfaz4ffchf3wo2s
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
