[
https://issues.apache.org/jira/browse/CB-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159402#comment-14159402
]
ASF GitHub Bot commented on CB-2520:
------------------------------------
GitHub user khawkins opened a pull request:
https://github.com/apache/cordova-ios/pull/111
Creating a customizable user agent
Fix for [CB-2520](https://issues.apache.org/jira/browse/CB-2520).
Presumably, we'd eventually want a more user-exposed entry path to this. But
this work should be a good first step to that.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/khawkins/cordova-ios CB-2520
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/111.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #111
----
commit 36476a8c0dd6f1ae07e519a3752ececc5228f3df
Author: Kevin Hawkins <[email protected]>
Date: 2014-10-05T02:45:54Z
Creating a customizable user agent
----
> iOS: "original" user agent needs to be overridable
> --------------------------------------------------
>
> Key: CB-2520
> URL: https://issues.apache.org/jira/browse/CB-2520
> Project: Apache Cordova
> Issue Type: New Feature
> Components: iOS
> Affects Versions: Master
> Reporter: Kevin Hawkins
> Labels: core
> Original Estimate: 8h
> Remaining Estimate: 8h
>
> Cordova's user agent management for iOS employs a scheme of setting a
> baseline "original" user agent, which by default conforms to the standard
> user agent a UIWebView would expose, and then optionally appending
> CDVViewController-specific data to it in the appropriate use cases, to manage
> whitelisting.
> Cordova shouldn't really care too much about the data that the original user
> agent exposes. I.e. it should be able to be overridden by a consumer, so
> that the consumer can supply its own user agent data. This is not
> technically possible with the current implementation of the CDVUserAgentUtil
> class, since it does not exist as a member of any instance class; it's truly
> static/global, so inheritance doesn't come into play.
> Even if an instance of CDVuserAgentUtil could be made a property of
> CDVViewController, or something else, it would be kind of weird for a
> consumer to inherit from what's essentially a static class, just to configure
> their own user agent data.
> There should be another mechanism for users to override the original user
> agent configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
