[
https://issues.apache.org/jira/browse/CB-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160276#comment-14160276
]
Patrick Mueller commented on CB-5718:
-------------------------------------
Andrew / James - thanks for the report and comment.
The patch here is easy enough - just the suggested fix to weinre.web/index.js -
that it's easier for me to do this myself.
Good to go after this single fix?
Andrew, had you tried picking up a new weinre release, for a fix to the second
problem?
> Detection of HTTPS broken
> -------------------------
>
> Key: CB-5718
> URL: https://issues.apache.org/jira/browse/CB-5718
> Project: Apache Cordova
> Issue Type: Bug
> Components: weinre
> Affects Versions: 2.0.0
> Reporter: Andrew Brock
> Assignee: Patrick Mueller
> Priority: Blocker
> Labels: https
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> 2 JS files don't correctly handle https:
> web/index.js(64):
> --- else if (protocol == "https:") {
> +++ else if (weinre_protocol == "https:") {
> web/target/target-script-min.js(3359):
> --- pattern = /(http:\/\/(.*?)\/)/;
> +++ pattern = /(https?:\/\/(.*?)\/)/;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
