[
https://issues.apache.org/jira/browse/CB-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14161876#comment-14161876
]
ASF GitHub Bot commented on CB-6994:
------------------------------------
Github user sgrebnov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/54#discussion_r18519168
--- Diff: www/FileWriter.js ---
@@ -100,9 +100,11 @@ FileWriter.prototype.write = function(data) {
var that=this;
var supportsBinary = (typeof window.Blob !== 'undefined' && typeof
window.ArrayBuffer !== 'undefined');
var isBinary;
+ var isWin8 = cordova.platformId === "windows8" || cordova.platformId
=== "windows";
// Check to see if the incoming data is a blob
- if (data instanceof File || (supportsBinary && data instanceof Blob)) {
+ if ((!isWin8 || !(data instanceof Blob || data instanceof File)) && //
ignore if Windows 8
--- End diff --
this is very complicated to understand, could you please see if this could
be made more human readable
> Windows 8 does not save big file transferred using Blob
> -------------------------------------------------------
>
> Key: CB-6994
> URL: https://issues.apache.org/jira/browse/CB-6994
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin File, Windows 8
> Affects Versions: 3.5.0
> Reporter: Maxime LUCE
> Assignee: Maxime LUCE
> Fix For: 3.6.0
>
>
> When trying to save Blob using FileWriter.write method, if the blob's size is
> too high, we get a stack overflow exception during the conversion of the blob
> into an basic array.
> WinRT (WinJS) provide a method to write Blob directly to the filesystem. It
> uses Streams so it's safe for memory.
> More info at :
> http://code.msdn.microsoft.com/windowsapps/Blob-Sample-0e35889e/sourcecode?fileId=43594&pathId=962515806
> Method : writeBlobToFile
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
