[ 
https://issues.apache.org/jira/browse/CB-7371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162396#comment-14162396
 ] 

ASF GitHub Bot commented on CB-7371:
------------------------------------

Github user martincgg commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/116#discussion_r18543665
  
    --- Diff: framework/src/org/apache/cordova/CordovaWebView.java ---
    @@ -427,7 +427,7 @@ void loadUrlNow(String url) {
             if (LOG.isLoggable(LOG.DEBUG) && !url.startsWith("javascript:")) {
                 LOG.d(TAG, ">>> loadUrlNow()");
             }
    -        if (url.startsWith("file://") || url.startsWith("javascript:") || 
whitelist.isUrlWhiteListed(url)) {
    +        if (url.startsWith("file://") || url.startsWith("javascript:") || 
(whitelist.isUrlWhiteListed(url) && !url.equals("about:blank"))) {
    --- End diff --
    
    Hi Andrew, I closed the JIRA item, but forgot to close this PR, this 
problem fixed indirectly on master.
    Thanks for the review anyway.


> [Android] App crashes after phone language change
> -------------------------------------------------
>
>                 Key: CB-7371
>                 URL: https://issues.apache.org/jira/browse/CB-7371
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 3.5.0
>         Environment: 4.2.2 (Jelly-Bean)
> 4.4.2 (KitKat)
>            Reporter: Martin Gonzalez
>            Assignee: Martin Gonzalez
>              Labels: android, crash
>             Fix For: 3.7.0
>
>
> After switching device language on android, the app will fails to reload 
> scenario:
> 1. Create new app 
> 2. open it and exit with the home button
> 3.Switch device language to or any other
> 4. Resume the app
> Expected result :
> the app should run
> Actual result:
> app crashes on first load
> Log:
> 07-28 16:24:10.018: D/CordovaActivity(25402): CordovaActivity.onDestroy()
> 07-28 16:24:10.028: D/CordovaWebView(25402): >>> loadUrlNow()
> 07-28 16:24:10.038: I/CordovaLog(25402): Changing log level to DEBUG(3)
> 07-28 16:24:10.038: I/CordovaLog(25402): Found start page location: 
> cdvtests/index.html
> 07-28 16:24:10.038: D/CordovaActivity(25402): CordovaActivity.onCreate()
> 07-28 16:24:10.048: D/CordovaActivity(25402): CordovaActivity.init()
> 07-28 16:24:10.058: D/CordovaWebView(25402): >>> 
> loadUrl(file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.068: D/CordovaWebView(25402): >>> loadUrlNow()
> 07-28 16:24:10.068: I/CordovaLog(25402): Found start page location: 
> cdvtests/index.html
> 07-28 16:24:10.068: D/CordovaActivity(25402): Resuming the App
> 07-28 16:24:10.068: D/CordovaActivity(25402): CB-3064: The errorUrl is null
> 07-28 16:24:10.078: D/CordovaWebViewClient(25402): onPageStarted(about:blank)
> 07-28 16:24:10.078: D/CordovaActivity(25402): 
> onMessage(onPageStarted,about:blank)
> 07-28 16:24:10.078: D/CordovaWebViewClient(25402): onPageFinished(about:blank)
> 07-28 16:24:10.078: D/CordovaActivity(25402): 
> onMessage(onPageFinished,about:blank)
> 07-28 16:24:10.078: D/CordovaActivity(25402): onMessage(exit,null)
> 07-28 16:24:10.088: D/CordovaWebViewClient(25402): 
> onPageStarted(file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.088: D/CordovaActivity(25402): 
> onMessage(onPageStarted,file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.108: D/CordovaActivity(25402): Paused the application!
> 07-28 16:24:10.108: D/CordovaWebView(25402): Handle the pause
> 07-28 16:24:10.148: D/CordovaActivity(25402): CordovaActivity.onDestroy()
> 07-28 16:24:10.148: D/CordovaWebView(25402): >>> loadUrlNow()
> 07-28 16:24:10.158: D/CordovaWebViewClient(25402): 
> onPageFinished(file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.158: D/CordovaActivity(25402): 
> onMessage(onPageFinished,file:///android_asset/www/cdvtests/index.html)
> 07-28 16:24:10.168: D/CordovaWebViewClient(25402): onPageStarted(about:blank)
> 07-28 16:24:10.168: D/CordovaActivity(25402): 
> onMessage(onPageStarted,about:blank)
> 07-28 16:24:10.188: D/CordovaWebViewClient(25402): onPageFinished(about:blank)
> 07-28 16:24:10.188: D/CordovaActivity(25402): 
> onMessage(onPageFinished,about:blank)
> 07-28 16:24:10.188: D/CordovaActivity(25402): onMessage(exit,null)
> 07-28 16:24:12.168: D/CordovaActivity(25402): onMessage(spinner,stop)
> 07-28 16:24:12.188: D/CordovaActivity(25402): onMessage(spinner,stop)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to