[
https://issues.apache.org/jira/browse/CB-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169876#comment-14169876
]
Mike Billau commented on CB-7499:
---------------------------------
Thanks Andrew for checking this out.
Agree about the <engine> tag.
To answer your question, yes plugins should check the API level.
I see you've already pulled in a fix to do this check:
https://github.com/apache/cordova-plugin-dialogs/commit/4cfe290b2a3e8f0aafb71a1ff4fbee4b710c8749
Tested on 2.3.3, looks great. Thanks.
> Cordova dialogs should support BIDI text
> ----------------------------------------
>
> Key: CB-7499
> URL: https://issues.apache.org/jira/browse/CB-7499
> Project: Apache Cordova
> Issue Type: Bug
> Components: Android, Plugin Dialogs
> Affects Versions: Master
> Reporter: Mike Billau
> Assignee: Mike Billau
> Priority: Minor
> Labels: bidirectional, globalization
> Fix For: 3.7.0
>
>
> Since API 19, Andorid has had the facilities to deal with bidirectional text,
> however, current Cordova notification implementation does not correctly
> handle bidirectional text in dialogs.
> We can see this is the case by first setting the language to Hebrew and then
> launching the following dialogs:
> navigator.notification.confirm("Pure English !!!", function(){}, "7");
> navigator.notification.confirm("עברית היא שפה מדוברת בIsrael !",
> function(){}, "8");
> Since we are in Hebrew, the base text direction will be RTL. This means that
> when we see the second notification with the Hebrew text, it will be
> right-justified. When we click and see the "Pure English !!!" notication,
> because locale is RTL, we should expect to see: "!!! Pure English" and it
> should be right-justified, however, we still see "Pure English !!!", left
> justified.
> http://w3-03.ibm.com/globalization/page/publish/4353
> Ideally you should be able to just add android:supportsRtl="true" to the
> manifest, however, this is doesn't seem to ne enough without setting the text
> direction to the locale for all of the dialogs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
