[
https://issues.apache.org/jira/browse/CB-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185687#comment-14185687
]
ASF GitHub Bot commented on CB-6472:
------------------------------------
GitHub user gorkem opened a pull request:
https://github.com/apache/cordova-lib/pull/115
CB-6472 Merge dictionaries when updating plist files
Merges the dictionaries on plist files if both plist and the value from
plugin.xml are dictionaries. This makes it consistent with how it behaves with
array values.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gorkem/cordova-lib CB-6472
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/115.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #115
----
commit 6bb5592d76ea3fc426ff87c0f7091dd9d985df1c
Author: Gorkem Ercan <[email protected]>
Date: 2014-10-27T17:35:09Z
[CB-6472] Adding content to -Info.plist - Unexpected behaviour
Merge instead of replace when the destination and source nodes
are both of type dictionary. Adds underscore.js as a dependency
commit 87173e00ee3242bf070343fe22b1644c10b1a994
Author: Gorkem Ercan <[email protected]>
Date: 2014-10-27T19:42:06Z
Tests for merging dictionaries
Tests plist, if dictionary keys are actually merged when it already exists.
----
> Adding content to -Info.plist - Unexpected behaviour
> ----------------------------------------------------
>
> Key: CB-6472
> URL: https://issues.apache.org/jira/browse/CB-6472
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugman
> Affects Versions: 3.4.0
> Environment: Mac OS X
> Reporter: Jean-Christophe Hoelt
> Priority: Minor
>
> Trying to add content NOT at the root of info.plist, to a node already having
> existing content.
> The existing content gets deleted, not merged with new content.
> Use case: a plugin providing Newsstand integration.
> Doing this in plugin.xml:
> <config-file target="*-Info.plist" parent="CFBundleIcons">
> <dict>
> <key>CFBundlePrimaryIcon</key>
> <dict>
> <key>UINewsstandIcon</key>
> <dict>
> ...
> Info.plist before install:
> <key>CFBundleIcons</key>
> <dict>
> <key>CFBundlePrimaryIcon</key>
> <dict>
> <key>CFBundleIconFiles</key>
> <array>
> ...
> </array>
> </dict>
> </dict>
> Info.plist after install:
> <key>CFBundleIcons</key>
> <dict>
> <key>CFBundlePrimaryIcon</key>
> <dict>
> <key>UINewsstandIcon</key>
> <dict>
> ...
> </dict>
> </dict>
> </dict>
> Info.plist expected:
> <key>CFBundleIcons</key>
> <dict>
> <key>CFBundlePrimaryIcon</key>
> <dict>
> <key>UINewsstandIcon</key>
> <dict>
> ...
> </dict>
> <key>CFBundleIconFiles</key>
> <array>
> ...
> </array>
> </dict>
> </dict>
> If this is not unexpected behaviour, then I'd make this issue a feature
> request: adding an option like "merge=true".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
